check code

helper/refill/api/xyz/moxj/RefillCallBack.php

@@ -43,7 +43,6 @@ class RefillCallBack implements refill\IRefillCallBack
         $order_id = $order_info['order_id'];
         
         $data['official_sn'] = strtolower($params['order']) == 'null' ? '' : $params['order'];
-
         if ($status === 'success') {
             Model('refill_order')->edit($order_id, $data);
             return [$order_id, true, false,true];

helper/refill/api/xyz/moxj_fs/RefillCallBack.php

@@ -30,18 +30,16 @@ class RefillCallBack implements refill\IRefillCallBack
         if (empty($order_info)) {
             return [false, false, false,false];
         }
-        $order_id = $order_info['order_id'];
 
+        $order_id = $order_info['order_id'];
         if ($status === 1) {
             $data['official_sn'] = strtolower($params['official_order_id']) == 'null' ? '' : $params['official_order_id'];
             Model('refill_order')->edit($order_id, $data);
-            return [$order_id, true, false,true];
-        }
-        elseif ($status === 0) {
-            return [$order_id, false, true,true];
-        }
-        else {
-            return [$order_id, false, false,false];
+            return [$order_id, true, false, true];
+        } elseif ($status === 0) {
+            return [$order_id, false, true, true];
+        } else {
+            return [$order_id, false, false, false];
         }
     }
 }

helper/refill/api/xyz/yikatong/RefillPhone.php

@@ -94,6 +94,8 @@ class RefillPhone extends refill\IRefillPhone
                 $order_state = ORDER_STATE_CANCEL;
             } elseif (in_array($status, [5011,5019],true)) {
                 $order_state = ORDER_STATE_SEND;
+            } elseif ($status === 5005 && (time() - $refill_info['commit_time'] >= 300)) {
+                $order_state = ORDER_STATE_NOEXIST;
             } else {
                 return [false, $resp['szRtnMsg']];
             }

helper/refill/api/xyz/yunchonggong/RefillPhone.php

@@ -45,14 +45,15 @@ class RefillPhone extends refill\IRefillPhone
         {
             Log::record($resp, Log::DEBUG);
             $resp = json_decode($resp, true);
+
             $nRtn = $resp['nRtn'];
             if (empty($resp)) {
                 return [false, '网络错误', true];
             } elseif ($nRtn === 0) {
                 return [true, '', false];
-            } elseif (in_array($nRtn, config::ERR_NO)) {
+            } elseif (in_array($nRtn, config::ERR_NO, true)) {
                 return [false, $resp['szRtnCode'], false];
-            } elseif (in_array($nRtn, [2050, 999])) {
+            } elseif (in_array($nRtn, [2050, 999], true)) {
                 $net_errno = "HTTP-{$nRtn}";
                 return [false, $resp['szRtnCode'], false];
             } else {
@@ -83,6 +84,7 @@ class RefillPhone extends refill\IRefillPhone
             if (empty($resp)) {
                 return [false, '网络错误'];
             }
+
             $status = $resp['nRtn'];
             if ($status === 5012) {
                 $updata['official_sn'] = $resp['szRtnMsg'];
@@ -90,13 +92,14 @@ class RefillPhone extends refill\IRefillPhone
                 $order_state = ORDER_STATE_SUCCESS;
             } elseif ($status === 5013) {
                 $order_state = ORDER_STATE_CANCEL;
-            } elseif (in_array($status, [5011, 5019])) {
+            } elseif (in_array($status, [5011,5019],true)) {
                 $order_state = ORDER_STATE_SEND;
             } elseif ($status === 5005 && (time() - $refill_info['commit_time'] >= 300)) {
                 $order_state = ORDER_STATE_NOEXIST;
             } else {
-                return [false, $status];
+                return [false, $resp['szRtnMsg']];
             }
+
             return [true, $order_state];
         }
     }

helper/refill/api/xyz/yunchonggong_yd/RefillPhone.php

@@ -45,14 +45,15 @@ class RefillPhone extends refill\IRefillPhone
         {
             Log::record($resp, Log::DEBUG);
             $resp = json_decode($resp, true);
-            $nRtn = intval($resp['nRtn']);
+
+            $nRtn = $resp['nRtn'];
             if (empty($resp)) {
                 return [false, '网络错误', true];
             } elseif ($nRtn === 0) {
                 return [true, '', false];
-            } elseif (in_array($nRtn, config::ERR_NOS)) {
+            } elseif (in_array($nRtn, config::ERR_NOS,true)) {
                 return [false, $resp['szRtnCode'], false];
-            } elseif (in_array($nRtn, [2050, 999])) {
+            } elseif (in_array($nRtn, [2050, 999], true)) {
                 $net_errno = "HTTP-{$nRtn}";
                 return [false, $resp['szRtnCode'], false];
             } else {
@@ -83,20 +84,22 @@ class RefillPhone extends refill\IRefillPhone
             if (empty($resp)) {
                 return [false, '网络错误'];
             }
-            $status = intval($resp['nRtn']);
+
+            $status = $resp['nRtn'];
             if ($status === 5012) {
                 $updata['official_sn'] = $resp['szRtnMsg'];
                 Model('refill_order')->edit($refill_info['order_id'], $updata);
                 $order_state = ORDER_STATE_SUCCESS;
             } elseif ($status === 5013) {
                 $order_state = ORDER_STATE_CANCEL;
-            } elseif (in_array($status, [5011, 5019])) {
+            } elseif (in_array($status, [5011,5019],true)) {
                 $order_state = ORDER_STATE_SEND;
             } elseif ($status === 5005 && (time() - $refill_info['commit_time'] >= 300)) {
                 $order_state = ORDER_STATE_NOEXIST;
             } else {
-                return [false, $status];
+                return [false, $resp['szRtnMsg']];
             }
+
             return [true, $order_state];
         }
     }
@@ -119,7 +122,7 @@ class RefillPhone extends refill\IRefillPhone
             $resp = json_decode($resp, true);
             if (empty($resp)) {
                 return [false, '网络错误'];
-            } elseif ($resp['nRtn'] == 0) {
+            } elseif ($resp['nRtn'] === 0) {
                 return [true, $resp['fBalance']];
             } else {
                 return [false, $resp['szRtnCode']];